improving the dark mode functionality on home page #867
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @charu1110! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work!
✅ Deploy Preview for vintagevibe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign |
|
@Anjaliavv51 is it good to merge ? |
|
@charu1110 I think feature need to be added to the whole website so that I can assign u Advanced |
|
@Anjaliavv51 ok i will work on it . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i made certain changes to improve the text visibility in dark mode ..
the issue was that the text becomes invisible when dark mode was on but i made changes so as in dark the text color will change accordingly in header section .
the same issue was on card section so i made a background set when dark mode is on and it matches with the color scheme too !
Related Issues
Type of PR
Screenshots / videos (if applicable)
BEFORE :
AFTER :
Checklist
mainbranch before making this PRAdditional context: